Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define cells to run independent of selection #65

Closed
wants to merge 9 commits into from

Conversation

krassowski
Copy link
Owner

@krassowski krassowski commented Aug 21, 2023

References

Addresses # 13361

Instead of relying on selection state for running cells (which is how individual run commands are implemented), save the cells to run before asynchronous actions to ensure that selection changes do not influence which cells get run.

Code changes

  • adds Private.runSelected() function
  • adds public NotebookActions.runCells() function
  • rewrites notebook:restart-and-run-to-selected and notebook:restart-run-all commands to use NotebookActions.runCells

User-facing changes

When restarting and re-running up to selected cell, the cell which was selected during invoking the command (rather than the cell selected after restart) will be the one executed in the end.

Backwards-incompatible changes

None I think.

@krassowski krassowski changed the title Define cells to independent of cell selection Define cells to run independent of selection Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment